Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PY-400][external] Move Meta Item & ItemQuery to folder #717

Merged
merged 7 commits into from
Nov 14, 2023
Merged

[PY-400][external] Move Meta Item & ItemQuery to folder #717

merged 7 commits into from
Nov 14, 2023

Conversation

JBWilkie
Copy link
Collaborator

Problem

Currently no Meta methods for moving items between folders

Solution

Introduced functions to do this for Meta Items & ItemQuery objects

Changelog

Meta methods to move Items & ItemQuery objects between folders

@linear Linear
Copy link

linear bot commented Nov 13, 2023

PY-400 Move item to folder

ex.

# `item` is of type Item, within meta scope

item.move_to_folder('folder_name')

# `items` is of type ItemQuery
items = team.datasets[0].items.where(some_query)

items.priority('folder_name') # will move all items in query

owencjones
owencjones approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@owencjones owencjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments to review, but not going to block a merge.

darwin/future/tests/meta/objects/test_itemmeta.py Show resolved Hide resolved
darwin/future/tests/meta/queries/test_item.py Outdated Show resolved Hide resolved
darwin/future/tests/meta/queries/test_item.py Show resolved Hide resolved
@owencjones owencjones merged commit c638ce8 into master Nov 14, 2023
@owencjones owencjones deleted the py-400 branch November 14, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owencjones owencjones owencjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JBWilkie @owencjones